[KERNEL][VARIANT] Basic write variant for kernel #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitOrigin-RevId: a917005aecfa72bc70a6414b675cd54ee548aa96
GitOrigin-RevId: dcfbc81ff53f26f4ec79ba52074c6f469928abf6
GitOrigin-RevId: 2fd73b5fe81d32fcb121ee36ff779b51c3441909
GitOrigin-RevId: 6eea012effffbb4d4f028385da890945f5bbdda2
GitOrigin-RevId: c6795716ca812eedecfdba07a72718432ae3d494
GitOrigin-RevId: d57235dc0d25247035cbfea5c05d5b0c533338fd
GitOrigin-RevId: fbe3747c7e71180f4b586fbfa74c9bc2489c4850
GitOrigin-RevId: 142b3b1b89003f6af4b061f0b8de2d0452570a3d
GitOrigin-RevId: fa79d744dde841bf6addf72fcd22be4d7b3a9d11
GitOrigin-RevId: db1f2f36a6e5f160c77d5ff00d8b946c734afc56
richardc-db
force-pushed
the
kernel_write_variant
branch
2 times, most recently
from
cd79425 to
96de7d8
Compare
richardc-db
commented
Mar 18, 2024
...faults/src/test/scala/io/delta/kernel/defaults/internal/parquet/ParquetFileWriterSuite.scala
Outdated
Show resolved
Hide resolved
GitOrigin-RevId: a5a2a9927ab5a2a1b8671389dea5742d43f65bc9
GitOrigin-RevId: 25b154d097966d5d2541243bcfd5c1d90bedab38
GitOrigin-RevId: ecd9c7204e4000526db1aaf0e220d1db38a67887
richardc-db
force-pushed
the
kernel_read_variant
branch
2 times, most recently
from
1d20a35 to
1c897a5
Compare
richardc-db
force-pushed
the
kernel_write_variant
branch
from
96de7d8 to
4f89c92
Compare
richardc-db
force-pushed
the
kernel_read_variant
branch
from
843995c to
a9a1c5b
Compare
richardc-db
force-pushed
the
kernel_write_variant
branch
from
7b1a803 to
cd199d6
Compare
richardc-db
force-pushed
the
kernel_read_variant
branch
2 times, most recently
from
844cb0b to
5722e8d
Compare
richardc-db
force-pushed
the
kernel_read_variant
branch
from
3860375 to
ddc75dc
Compare
richardc-db
force-pushed
the
kernel_read_variant
branch
2 times, most recently
from
c06180d to
6a879b5
Compare
richardc-db
force-pushed
the
kernel_read_variant
branch
from
6a879b5 to
2032fa3
Compare
richardc-db
pushed a commit
that referenced
this pull request
May 13, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> Split the main PR delta-io#4265 for faster review add `ClusteringMetadataDomain` which could generate the clustering domain metadata like ``` { "domainMetadata": { "domain": "delta.clustering", "configuration": "{\"clusteringColumns\":[\"col-daadafd7-7c20-4697-98f8-bff70199b1f9\", \"col-5abe0e80-cf57-47ac-9ffc-a861a3d1077e\"]}", "removed": false } } ``` ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> unit tests ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. -->
richardc-db
pushed a commit
that referenced
this pull request
Sep 8, 2025
…ataValidatorAndUpdaterSuites (delta-io#4739) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> This PR is a refactor-only change that restructures the test suites related to IcebergCompatMetadataValidatorAndUpdater. ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> Existing test suites. ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. -->
richardc-db
pushed a commit
that referenced
this pull request
Sep 8, 2025
…-io#4775) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> Follow up to delta-io#4734 and removes a missed function definition during refactoring. ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> Unit tests. ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relies on #2
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?